fix: Wave generator UI changes #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityastic
approved these changes
Aug 23, 2019
|
@adityastic it's WIP |
neel1998
force-pushed
the
wave_gen_ui
branch
2 times, most recently
from
6797b02 to
0711c76
Compare
neel1998
added
Enhancement
CloudyPadmal
requested changes
Aug 23, 2019
There was a problem hiding this comment.
- Apply the switching behavior to "Freq" and "Phase" buttons.
- Remove decimals from from both "Frequency" and "Phase". Use whole number; no decimals
- No need to show "Wave Pins will be disabled" toast as it was something used in the older UI
- Add two buttons (half the size of what it is now) instead of one "Sine" button in analog mode and use switching behavior (active one is red) to both of them. Otherwise user have to click and see what that button do. (Discussed in meeting)
CloudyPadmal
requested changes
Aug 23, 2019
|
@CloudyPadmal I have made the requested changes |
|
@mariobehling @CloudyPadmal please review and merge so that I can start working on wave preview issue #1938 |
CloudyPadmal
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1956
Changes:
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
wave.zip