Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : Correcting LA pins description. #1993

Merged
merged 1 commit into from
Oct 26, 2019
Merged

fix : Correcting LA pins description. #1993

merged 1 commit into from
Oct 26, 2019

Conversation

dipu989
Copy link
Contributor

@dipu989 dipu989 commented Oct 25, 2019

Fixes #1991

Changes:
Corrected Logical analyzer pins descriptions.

Gif for the changes:
ezgif com-optimize

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
apkDebug.zip

neel1998
neel1998 approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@neel1998 neel1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@neel1998 neel1998 requested a review from CloudyPadmal October 25, 2019 19:34
@CloudyPadmal CloudyPadmal merged commit 6f9c2ed into fossasia:development Oct 26, 2019
@CloudyPadmal CloudyPadmal added the Fix Solution to an existing issue in app label Oct 26, 2019
@dipu989 dipu989 mentioned this pull request Nov 7, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neel1998 neel1998 neel1998 approved these changes

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

@adityastic adityastic adityastic approved these changes

Assignees
No one assigned
Labels
Fix Solution to an existing issue in app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong information displayed in Pin Layout Back section.
4 participants
@dipu989 @adityastic @CloudyPadmal @neel1998