Fixes #2046 Fixes crash when data is loaded which has been written on… #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… device with German locale
marcnause
requested review from
neel1998,
CloudyPadmal,
cweitat,
mariobehling and
lorenzgerber
mariobehling
approved these changes
Feb 4, 2020
CloudyPadmal
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… device with German locale
Fixes #2046
Changes: The locale has been changed from default to ROOT where numbers which are parsed later are formatted. The CSV logger has been changed slightly: whole lines are added now which allows to move line break logic to a new class (CSVDataLine) instead of having it in the classes which create the data.
Screenshot/s for the changes: No layout changes
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: app-fdroid-debug.zip