Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #2024 - Implemented Soundmeter #2107

Merged
merged 1 commit into from
May 16, 2020

Conversation

abhishekbisht1429
Copy link
Contributor

Fixes #2024 Completed the implementation of Soundmeter

Changes: Implemented the feature to record the sound level data, play/pause recorded data and added the plot of real time sound level data on the chart.

Screenshot/s for the changes:
fix2024

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
fix#2024.zip

Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reckoner1429 this is great. Sorry for the long delay. We'll merge this and move forward with improvements. Thanks for the PR. 👍

@CloudyPadmal CloudyPadmal requested a review from cweitat May 16, 2020 09:37
@CloudyPadmal CloudyPadmal added the Feature New addition to the existing app label May 16, 2020
@abhishekbisht1429
Copy link
Contributor Author

abhishekbisht1429 commented May 16, 2020

@CloudyPadmal Thanks for the approval. I am glad it got, merged else my work would have been in vain 👍😊

@cweitat cweitat merged commit bee0427 into fossasia:development May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New addition to the existing app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Soundmeter/Sonometer
3 participants