Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: substitute Travis with Github Actions #2149

Merged
merged 9 commits into from
Jun 4, 2021

Conversation

CodeWithSouma
Copy link
Member

@mariobehling @CloudyPadmal

Substitute Travis with Github Actions, #2148

  • remove travis.yml
  • add android.yml

@CodeWithSouma
Copy link
Member Author

@CloudyPadmal sir can you help regarding this problem #2149. how to fix this ...

@CloudyPadmal
Copy link
Collaborator

Hello @CodeWithSouma , Travis build is not currently working for the repos.. That's why the build is failing. So just ignore that for now. Let me check the updates you made.

@anurag0singh
Copy link

Why was this rejected?

@anurag0singh
Copy link

@CloudyPadmal Sir why was the Github CI is rejected in this particular merge request?

Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's go ahead with this and see..

@CloudyPadmal
Copy link
Collaborator

@anurag0singh Travis CI has no more free credits to use by the repos. So we are moving to GitHub actions

Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CodeWithSouma ,

In Travis CI build, when a PR is merged into development branch, an APK file is auto generated. Same happens when the development branch is merged to main branch. Shall we add a function like that to GitHub actions?

@CloudyPadmal CloudyPadmal changed the title Substitute Travis with Github Actions chore: substitute Travis with Github Actions Apr 1, 2021
@CloudyPadmal CloudyPadmal added the Chore Changes to things that do not go into production label Apr 1, 2021
@CodeWithSouma
Copy link
Member Author

Hi @CodeWithSouma ,

In Travis CI build, when a PR is merged into development branch, an APK file is auto generated. Same happens when the development branch is merged to main branch. Shall we add a function like that to GitHub actions?

I am trying to implement that thing

@CloudyPadmal
Copy link
Collaborator

@CodeWithSouma Perfect! Thank you..

@CodeWithSouma
Copy link
Member Author

@CloudyPadmal sir, I add the jobs in GitHub actions, an APK file that is auto-generated.

.github/workflows/android.yml Outdated Show resolved Hide resolved
.github/workflows/android.yml Outdated Show resolved Hide resolved
.github/workflows/android.yml Outdated Show resolved Hide resolved
.github/workflows/android.yml Outdated Show resolved Hide resolved
.github/workflows/android.yml Outdated Show resolved Hide resolved
Comment on lines +35 to +39
- name: Upload APK
uses: actions/upload-artifact@v1
with:
name: app
path: app/build/outputs/apk/debug/app-debug.apk
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not simple as that. We use two build flavours and once built, a script is used to upload the files to apk branch. https://github.com/fossasia/pslab-android/blob/development/.travis.yml#L37

@CloudyPadmal
Copy link
Collaborator

Also, can you test the action setup in a demo branch? Then we can see if it's building without any error.

CodeWithSouma and others added 5 commits April 23, 2021 03:29
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
@kartikeysaran
Copy link
Contributor

@CodeWithSouma are you still working on this ?

@CodeWithSouma
Copy link
Member Author

@CodeWithSouma are you still working on this ?

yes

@kartikeysaran
Copy link
Contributor

@CodeWithSouma are you still working on this ?

yes

Okay ! 🍻

Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this and let's move forward with improvements.

@CloudyPadmal CloudyPadmal merged commit 879c94b into fossasia:development Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Changes to things that do not go into production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants