-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: substitute Travis with Github Actions #2149
chore: substitute Travis with Github Actions #2149
Conversation
@CloudyPadmal sir can you help regarding this problem #2149. how to fix this ... |
Hello @CodeWithSouma , Travis build is not currently working for the repos.. That's why the build is failing. So just ignore that for now. Let me check the updates you made. |
Why was this rejected? |
@CloudyPadmal Sir why was the Github CI is rejected in this particular merge request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's go ahead with this and see..
@anurag0singh Travis CI has no more free credits to use by the repos. So we are moving to GitHub actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CodeWithSouma ,
In Travis CI build, when a PR is merged into development branch, an APK file is auto generated. Same happens when the development branch is merged to main branch. Shall we add a function like that to GitHub actions?
I am trying to implement that thing |
@CodeWithSouma Perfect! Thank you.. |
@CloudyPadmal sir, I add the jobs in GitHub actions, an APK file that is auto-generated. |
- name: Upload APK | ||
uses: actions/upload-artifact@v1 | ||
with: | ||
name: app | ||
path: app/build/outputs/apk/debug/app-debug.apk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not simple as that. We use two build flavours and once built, a script is used to upload the files to apk branch. https://github.com/fossasia/pslab-android/blob/development/.travis.yml#L37
Also, can you test the action setup in a demo branch? Then we can see if it's building without any error. |
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
@CodeWithSouma are you still working on this ? |
yes |
Okay ! 🍻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this and let's move forward with improvements.
@mariobehling @CloudyPadmal
Substitute Travis with Github Actions, #2148