Changing Delete Log SnackBar #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon deletion of a logged data, the toast message should show "Log Deleted" but for some devices like Oscilloscope, it is showing "Nothing to delete" upon deletion of a log.
|
@CodeWithSouma Thanks for the review. Please do merge the PR into main. |
CloudyPadmal
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon deletion of a logged data, the toast message should show "Log Deleted" but for some devices like Oscilloscope, it is showing "Nothing to delete" upon deletion of a log.
Fixes #2168
Changes: The condition statement written to decide whether the snackbar should show "Log Deleted" or "Nothing to Delete" is not required and directly "Log Deleted" message can be shown as when there is nothing in the log then there is no option for the user to delete a log as the items menu sets "Delete All" menu option visibility to false.
Screenshot/s for the changes:
Before Changes:
After changes:
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
delete-log-toast.zip