docs: update guide of Wave generator in strings.xml #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the guide of Wave Generator in the third line, it is written "allow us to changes" which should be "allows us to change".
CodeWithSouma
approved these changes
Jan 19, 2021
app/src/main/res/values/strings.xml
Outdated
| @@ -796,7 +796,7 @@ | |||
| <string name="hide_guide_text">Hide Guide</string> | |||
|
|
|||
| <string name="wave_gen_guide_intro">The wave generator can be used to generate different types of waves like | |||
| Sine wave, Square wave, Saw Tooth wave and allow us to changes their characteristics like frequency, phase, duty. | |||
| Sine wave, Square wave, Saw Tooth wave and allows us to change their characteristics like frequency, phase, duty. | |||
There was a problem hiding this comment.
This is a simple mistake try to fix some big issue.
There was a problem hiding this comment.
Ok, thank you, sir, for the review.
CloudyPadmal
requested changes
Apr 1, 2021
CloudyPadmal
changed the title
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
CloudyPadmal
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the guide of Wave Generator in the third line, it is written "allow us to changes" which should be "allows us to change".
Changes:
In line 799 of strings.xml "allow us to changes" is changed to "allows us to change".