Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated setupGuideLayout in abstract class PSLabSensor to hide image if not available in a sensor's bottomsheet guide #2178

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

Ekagra
Copy link
Contributor

@Ekagra Ekagra commented Jan 21, 2021

Fixes: [empty imageview is sensors bottomsheet guide]

Changes: [updated setupGuideLayout in abstract class PSLabSensor to hide image if not available in a sensor's bottomsheet guide]

Screenshot/s for the changes:
Before-------------------------------------------------------------------------------------------------------------After

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

Copy link
Member

@asaikarthikeya asaikarthikeya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In every other instrument this space is filled with a PSlab hardware related image , I think adding a image would be better since it improve regularity in app . This would be a optimal solution till we get a image. Thank you.

Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an image instead of hiding the view.

@CloudyPadmal CloudyPadmal added the Documentation Non-code related documentation tasks label Apr 1, 2021
@CloudyPadmal
Copy link
Collaborator

Also try to shorten the PR title

@Ekagra
Copy link
Contributor Author

Ekagra commented Apr 4, 2021

@CloudyPadmal what image should I add?

@Ekagra
Copy link
Contributor Author

Ekagra commented Apr 4, 2021

The view is only hidden if there's no image to display like right now, do you want me to add a placeholder?

@CloudyPadmal CloudyPadmal merged commit db88ff7 into fossasia:development Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Non-code related documentation tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants