Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve compass UI #2183

Merged
merged 4 commits into from
Jun 4, 2021
Merged

feat: improve compass UI #2183

merged 4 commits into from
Jun 4, 2021

Conversation

CodeWithSouma
Copy link
Member

Impove compass instrument UI

@CloudyPadmal sir, please check this PR

Changes:

  • Remove unnecessary RelativeLayout and substitute with LinearLayout
  • Update compass image
  • fix some margin

Screenshot/s for the changes:

Compass UI improve

APK for testing:
app-fdroid-debug.zip

@CodeWithSouma
Copy link
Member Author

@CloudyPadmal sir, please check this PR.

CloudyPadmal
CloudyPadmal requested changes Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and good job with LinearLayout. However, the images added count as about 1MB increase in space which was about 70KB earlier. Let's revert the images back.

@CloudyPadmal CloudyPadmal added Enhancement Improvement to an existing feature Status: Review Required Requested reviews from peers and maintainers labels Apr 1, 2021
@CloudyPadmal CloudyPadmal changed the title Improve compass UI feat: improve compass UI Apr 1, 2021
@CodeWithSouma
Copy link
Member Author

Looks nice and good job with LinearLayout. However, the images added count as about 1MB increase in space which was about 70KB earlier. Let's revert the images back.

Sir previous image looks back-dated I am trying to reduce the size of the image

@CloudyPadmal CloudyPadmal merged commit a8ab6a7 into fossasia:development Jun 4, 2021
@CloudyPadmal CloudyPadmal removed the Status: Review Required Requested reviews from peers and maintainers label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

Assignees

@CodeWithSouma CodeWithSouma

Labels
Enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodeWithSouma @CloudyPadmal