fix: updating "Delete All Data" operation #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code has been modified to check whether any log is present while deleting and if no logs are present then the "Delete All Data" menu option shows a snackbar "Nothing To Delete".
CloudyPadmal
requested changes
Apr 1, 2021
CloudyPadmal
changed the title
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
CloudyPadmal
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been modified to check whether any log is present while deleting and if no logs are present then the "Delete All Data" menu option shows a snackbar "Nothing To Delete".
Fixes #2184
Changes:
In the onOptionsItemSelected function under the category of R.id.delete_all an if condition is added to check whether the size of LocalDataLog is greater than 0 or not. If it is 0 then the "Delete All Data" displays a snackbar "Nothing to delete", otherwise functions normally as before.
Screenshot/s for the changes:
Before:
Delete-all-items-doing-nothing-menu-item.mp4
After:
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
app-fdroid-debug.zip