Minor improvement in faq fragment #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CloudyPadmal can you please review |
CodeWithSouma
suggested changes
Mar 18, 2021
| @@ -36,6 +36,7 @@ | |||
| android:paddingBottom="@dimen/text_padding_top" | |||
| android:paddingLeft="@dimen/text_padding_top" | |||
| android:paddingTop="@dimen/text_padding_top" | |||
| android:paddingRight="@dimen/text_padding_top" | |||
There was a problem hiding this comment.
hey, please refactor this property text_padding_top with a generic name like faq_text_padding
There was a problem hiding this comment.
ok, I'll do it. Thanks for that
CloudyPadmal
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
Looks good. I'll merge this one.
But I think, we are wasting a lot of space on letter "Q:". I believe we can omit that and have the question expand the whole view. May be @Abhinavtdk or @CodeWithSouma can work on that?
Yea, I'll work on that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2200
Changes:
Added padding right to list_group.xml (displays question in faq fragment)
Screenshot/s for the changes:
improved_ui_faq.mp4
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
minor_ui_improvement_faq.zip