Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Wave Generator saving empty csv file #2215

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Fix: Wave Generator saving empty csv file #2215

merged 3 commits into from
Jun 4, 2021

Conversation

kartikeysaran
Copy link
Contributor

Fixes #2056
Fixes #2045

Changes: No more checking for connected device as wave generator works with device speakers

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

@CloudyPadmal CloudyPadmal merged commit f6f7ddc into fossasia:development Jun 4, 2021
@CloudyPadmal CloudyPadmal added the Fix Solution to an existing issue in app label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

Assignees

@kartikeysaran kartikeysaran

Labels
Fix Solution to an existing issue in app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Record option not working (Wave Generator) Wave generator: Empty .csv files
2 participants
@kartikeysaran @CloudyPadmal