Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2271 crash on closing WaveGenerator Screen #2272

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Fixes #2271 crash on closing WaveGenerator Screen #2272

merged 1 commit into from
Oct 28, 2021

Conversation

BishyanKar
Copy link
Contributor

Fixes #2271

Changes:

  • Null check was added in onBackPressed of WaveGeneratorActiviy for the produceSoundTask object.

Screen shots for the changes:

WhatsApp.Video.2021-10-28.at.16.10.30.mp4

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding any value.
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml.
  • I have reformatted code and fixed indentation in every file included in this pull request
  • My code does not contain any extra lines or extra spaces.
  • I have requested reviews from maintainers.

CloudyPadmal
CloudyPadmal approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! 👍

@CloudyPadmal CloudyPadmal merged commit 67b1fb3 into fossasia:development Oct 28, 2021
@BishyanKar
Copy link
Contributor Author

I would really appreciate if you add hacktoberfest-accepted label for this PR
Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BishyanKar @CloudyPadmal