fix : Recording starts even when device not connected. #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
requested changes
Jan 14, 2022
|
Fixed the problems. |
CloudyPadmal
requested changes
Jan 15, 2022
|
Also there are several commits related to gradle fixes. Update the PR and squash commits into one. https://github.com/fossasia/pslab-android#how-to-git-squash |
|
@CloudyPadmal I tried to change the settings in my IDE and then reformat the code but I don't know why it is still shuffling some parts. The app is working fine though and the fixes I made are reflected there. |
CloudyPadmal
requested changes
Jan 16, 2022
| @@ -316,9 +318,12 @@ public boolean onOptionsItemSelected(MenuItem item) { | |||
| will fire up. If user declines to give permission, don't do anything. | |||
| */ | |||
| case R.id.record_data: | |||
| if (!isRecording) { | |||
| if (!isRecording && (!sensorNotFound() || scienceLab.isConnected())) { | |||
There was a problem hiding this comment.
According to this logic, if PSLab is connected, it doesn't check the sensor test right?
There was a problem hiding this comment.
It checks but user would be able to start the recording nevertheless since PSLab is connected.
CloudyPadmal
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2093
Changes:
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard-coding any value.strings.xml,dimens.xmlorcolors.xml.