Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed flavor settings #2306

Closed
wants to merge 6 commits into from
Closed

Removed flavor settings #2306

wants to merge 6 commits into from

Conversation

apoorva-raj
Copy link
Contributor

Fixes #2305

Changes:
Removed flavor settings

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding any value.
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml.
  • I have reformatted code and fixed indentation in every file included in this pull request
  • My code does not contain any extra lines or extra spaces.
  • I have requested reviews from maintainers.

@CloudyPadmal
Copy link
Collaborator

CloudyPadmal commented Jan 21, 2022 •
edited
Loading

Make sure you have one commit per pull request. Keep the branch clean. I also noticed that you're using development branch for features. Creating a new branch for each PR make things easier to manage.

@apoorva-raj
Copy link
Contributor Author

Okay, I'll close this PR and raise a new PR with a new branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apoorva-raj @CloudyPadmal