Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes incompatbility with Python 2.7 - issue #548 #550

Closed
wants to merge 1 commit into from
Closed

Fixes incompatbility with Python 2.7 - issue #548 #550

wants to merge 1 commit into from

Conversation

vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented Jan 15, 2019 •
edited
Loading

Fixes #548

Description

Use io.open to be compatible with Python 2 and Python 3.

How Has This Been Tested?

python --version
> Python 2.7.15 :: Anaconda, Inc.
python setup.py build

and

python --version
> Python 3.6.8 :: Anaconda, Inc.
python setup.py build

@JackUrb JackUrb self-requested a review January 15, 2019 16:06
@JackUrb
Copy link
Contributor

JackUrb commented Jan 15, 2019

Thanks for the fix here @vfdev-5 - I hadn't thought to test python 2 in #544.

facebook-github-bot
facebook-github-bot reviewed Jan 15, 2019
View reviewed changes
Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackUrb is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

menshikh-iv added a commit to piskvorky/gensim that referenced this pull request Jan 16, 2019
@menshikh-iv
unpin visdom back (bug fixed)
5509bd3 
See 
- fossasia/visdom#550
- fossasia/visdom#548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@JackUrb JackUrb JackUrb approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vfdev-5 @JackUrb @facebook-github-bot