Feat/readme #99
Merged
Feat/readme #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Layout/Navbar/items.tsx
| @@ -0,0 +1,31 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
Great addition, I will rewrite other places with this hook after merge.
| "react-live": "^4.1.5", | ||
| "react-pdf": "^7.7.3", | ||
| "react-router-dom": "6.22.3", | ||
| "react-shepherd": "^4.3.0", | ||
| "react-sizeme": "^3.0.2", | ||
| "recharts": "2.12.3", | ||
| "rehype-katex": "^7.0.0", |
There was a problem hiding this comment.
@ThijsZijdel have we included example tempaltes of how to use these libraries in the the module? Ideally it'd be great if user knows somehow that they can write math markup.
also why two different plugins? isn't rehype-katex same as remark-math?
|
|
||
| So you can use *markdown* and <em>HTML</em>. | ||
|
|
||
| $\\frac{-30}{8}$ |
There was a problem hiding this comment.
ah here's math syntax I guess, looks goot to me
| </Button> | ||
| ) : null} | ||
| </Group> | ||
| <div style={{ width: "100%", height: "95%", display: "flex" }}> |
There was a problem hiding this comment.
PS: Mantine has Flex or Group, if you just want a div with display:flex.
you can also do <Box display="flex"> for simplicity if you want.
| {Object.keys(templates).map((key) => { | ||
| const template = templates[key as keyof typeof templates]; | ||
| return ( | ||
| <div |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readme feature editor is mostly done. Will inherit the extensions of the main MD editor in a later PR.
[Feature discussion] Readme generator #94