-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Benchmarking Compatibility to PaddingFree Plugin #66
Merged
fabianlim
merged 6 commits into
foundation-model-stack:main
from
achew010:orca-math-bench
Aug 19, 2024
Merged
Add Benchmarking Compatibility to PaddingFree Plugin #66
fabianlim
merged 6 commits into
foundation-model-stack:main
from
achew010:orca-math-bench
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianlim
reviewed
Aug 15, 2024
plugins/attention-and-distributed-packing/src/fms_acceleration_aadp/flash_attn.py
Show resolved
Hide resolved
fabianlim
reviewed
Aug 15, 2024
fabianlim
reviewed
Aug 15, 2024
fabianlim
reviewed
Aug 15, 2024
fabianlim
reviewed
Aug 15, 2024
fabianlim
requested changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have questions and concerns
fabianlim
reviewed
Aug 15, 2024
fabianlim
reviewed
Aug 15, 2024
fabianlim
reviewed
Aug 15, 2024
Please fix the DCO |
fabianlim
reviewed
Aug 15, 2024
fabianlim
reviewed
Aug 15, 2024
fabianlim
reviewed
Aug 16, 2024
fabianlim
reviewed
Aug 16, 2024
@achew010 if we figure out what is the issue and if it requires some significant change in the design of the accelerated-peft plugin, this needs to be documented |
achew010
force-pushed
the
orca-math-bench
branch
from
August 19, 2024 01:47
0fe0867
to
97529d2
Compare
Signed-off-by: 1000850000 user <aaron.chew1@ibm.com>
Signed-off-by: 1000850000 user <aaron.chew1@ibm.com>
Signed-off-by: 1000850000 user <aaron.chew1@ibm.com>
Co-authored-by: Yu Chin Fabian Lim <fabianlim@users.noreply.github.com> Signed-off-by: 1000850000 user <aaron.chew1@ibm.com>
achew010
force-pushed
the
orca-math-bench
branch
from
August 19, 2024 01:50
02a11f9
to
81f52ca
Compare
Signed-off-by: 1000850000 user <aaron.chew1@ibm.com>
Signed-off-by: 1000850000 user <aaron.chew1@ibm.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides support to run the benchmark for the AADP plugin
Key items:
data_processing
stanza inscenarios.yaml
to configure the benchmark dataset and define formatting using Jinja templatebenchmark.py
Benchmarks (Mistral 7B)
Benchmarks on Flan shows the improvement from PF is consistent with Transformers
NOTE: there are some regressions that affected the below results #70
Subset of Flan
run
bash scripts/run_benchmarks.sh "1 2" "benchmark_outputs/flan" "scenarios-flan.yaml "none""
Subset of Orca-Math
run
bash scripts/run_benchmarks.sh "1 2" "benchmark_outputs/orca" "scenarios-orca.yaml "none""
Benchmarks on Orca-Math show improvement from PaddingFree matches Transformers
Single Device
Two Device