Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow empty master if devices found on pod #178

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

sunya-ch
Copy link
Collaborator

This PR is an extension of previous PR #153 to prevent the issue when daemon pod has restarted during the job is running and cache has gone.

error:

zero config on cmdDel

As host-device deletion, there is no need of the master name. We add steps to assign the pod device IDs back to response when the daemon has no information of master device names.

after this change:

  • daemon return the device IDs with a list of empty master names
return: {[<device ID>] [ ]
  • CNI can successfully execute the deletion
Exec DEL net1-0

Signed-off-by: Sunyanan Choochotkaew sunyanan.choochotkaew1@ibm.com

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
@sunya-ch sunya-ch merged commit 1863bb2 into foundation-model-stack:v1.2.0 Feb 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant