Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify expanded menus #7326

Merged
merged 2 commits into from
Dec 18, 2015
Merged

Simplify expanded menus #7326

merged 2 commits into from
Dec 18, 2015

Conversation

slavanga
Copy link
Contributor

@slavanga slavanga commented Dec 1, 2015

Fixes #7192

@andycochran
Copy link
Contributor

Why table-layout: fixed instead of auto?

@slavanga
Copy link
Contributor Author

slavanga commented Dec 1, 2015

Because the auto-width mixin will output a large amount of unneeded CSS.
See: https://github.com/zurb/foundation-sites/blob/develop/dist/foundation.css#L2279-L2293

Setting table-layout: fixed will equalize the items just as well.

@gakimball
Copy link
Contributor

@slavanga Thanks for putting this together! What browsers were you able to test in?

@gakimball
Copy link
Contributor

Also, we use the auto layout mixin on button groups as well, if you're interested in implementing it there as well.

@andycochran
Copy link
Contributor

Sorry, I was confused (was thinking about inline menus). 👍

@slavanga
Copy link
Contributor Author

slavanga commented Dec 1, 2015

@gakimball This method is basically supported in every browser that can handle table display (caniuse)

@gakimball gakimball added this to the v6.1 milestone Dec 9, 2015
gakimball added a commit that referenced this pull request Dec 18, 2015
@gakimball gakimball merged commit 8d416ea into foundation:develop Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants