Issue #7441 Enable non-list elements in Accordions #7469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of selecting an `li` element, I set the selector to `accordion-item`. I tested using nested div elements instead of a list and it worked correctly.
|
See #7231 |
If no list elements are returned initially, this checks for the presence of the data-accordion-item attribute.
|
I've added an additional check for the data attribute in the logic. I have it first check for the list element and if zero are returned, then look for the attribute. I tested it using two separate accordion components, one using nested |
zurbchris
added a commit
that referenced
this pull request
Dec 11, 2015
Issue #7441 Enable non-list elements in Accordions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7441 Instead of selecting an
lielement, I set the selector toaccordion-item. I tested using nested div elements instead of a list and it worked correctly.