Drilldown height calculation with long titles #8320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to check the entire height of each submenu
| @@ -39,7 +39,7 @@ $drilldown-background: $white !default; | |||
| top: 0; | |||
| #{$global-left}: 100%; | |||
| z-index: -1; | |||
| height: 100%; | |||
| // height: 100%; | |||
There was a problem hiding this comment.
@kball @gakimball I'm finding that this line introduces a bug when a submenu is not as tall as the view port where the submenu's parent still shows below the last item of the active submenu. Setting
min-height: 100%;seems to do the trick.
I hesitate to put in a PR because #9239 includes much more comprehensive updates for sizing.
There was a problem hiding this comment.
Yeah, this appears to be responsible for #9368. Looking into 9239 now.
|
Not really working correctly when one of the submenus are longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Drilldown plugin reads the height of each menu inside of it, and sets the height of the whole menu to match the tallest one. However, the calculated height will be wrong if any menu items differ in height, as reported in #7070.
This is because the total menu height is calculated by taking the height of the first item in the list, and multiplying it by the number of items in the menu.
This change instead just calculates the height of the entire menu all at once, so it will be accurate.
However, the call to
.getBoundingClientRect()manages to be inaccurate. In the test case I put together, the height calculated is always off by 10 pixels, and I'm not sure why.To finish this fix, we need the height calculated accurately.