-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed deploy:dist and deploy:plugins tasks #9078
Conversation
Hi @rafibomb , So at the end, both Package Content and
|
To see the correct results, you have to run these tasks:
Otherwise, I think you probably cannot figure out the changes. |
c7c45fa
to
ac70ef1
Compare
…n the dist folder
Seems good to me, but we'll probably want to write a migration note upon release. |
The Basic template for v6.3.0-rc1 isn't completely built by default following a CLI "foundation new" command. The project's css folder is missing. The project's index.html won't have working styles out of the box. After issuing a "foundation build" command, the project's css folder is generated and the index.html works. However, there is no project-level "dist" directory. I'm new to Foundation. It's not clear to me if there's supposed to be a project-level "dist" directory in v6.3.0 based on the latest release notes. Instead, the css and js folders are installed at the root level of the project as in prior versions. I installed Foundation via npm on Windows 7. |
@jwatkin thanks for trying this out! I don't think we're going to have a project level "dist" folder inside the templates, this is the framework itself... For trying the basic template, can you try out this branch (not yet merged - we're still tweaking some final stuff in 6.3): https://github.com/zurb/foundation-sites-template/tree/v6.3 |
Fixed the gulp tasks:
deploy:dist
anddeploy:plugins
, so the output will be:dist/
: Compiled files.css/
: Compiled CSS files. Includes minified and unminified files.js/
: Concatenated JavaScript files. Includes minified and unminified files.plugins/
: Standalone JavaScript plugins.Look at this for more details #8863
Note ❗
This PR is a replacement for that PR #8862