Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deploy:dist and deploy:plugins tasks #9078

Merged
merged 2 commits into from
Oct 31, 2016

Conversation

abdullahsalem
Copy link
Contributor

Fixed the gulp tasks: deploy:dist and deploy:plugins, so the output will be:

  • dist/: Compiled files.
    • css/: Compiled CSS files. Includes minified and unminified files.
    • js/: Concatenated JavaScript files. Includes minified and unminified files.
      • plugins/: Standalone JavaScript plugins.

Look at this for more details #8863

Note ❗

This PR is a replacement for that PR #8862

@abdullahsalem
Copy link
Contributor Author

Hi @rafibomb ,
In this merged PR #8863, I added the plugins/ folder to the Package Content section, in the Installation page.
And in this new PR, I fixed these deployment tasks: deploy:dist and deploy:plugins, to make the dist folder exactly looks like what has been written in the Package Content.

So at the end, both Package Content and dist folder should look like:

  • dist/: Compiled files.
    • css/: Compiled CSS files. Includes minified and unminified files.
    • js/: Concatenated JavaScript files. Includes minified and unminified files.
      • plugins/: Standalone JavaScript plugins.

@abdullahsalem
Copy link
Contributor Author

To see the correct results, you have to run these tasks:

  • build
  • deploy:dist
  • deploy:plugins

Otherwise, I think you probably cannot figure out the changes.

@abdullahsalem abdullahsalem added this to the 6.3 milestone Aug 10, 2016
@kball
Copy link
Contributor

kball commented Oct 31, 2016

Seems good to me, but we'll probably want to write a migration note upon release.

@kball kball merged commit 289f13f into foundation:v6.3 Oct 31, 2016
@jwatkin
Copy link

jwatkin commented Dec 5, 2016

The Basic template for v6.3.0-rc1 isn't completely built by default following a CLI "foundation new" command. The project's css folder is missing. The project's index.html won't have working styles out of the box. After issuing a "foundation build" command, the project's css folder is generated and the index.html works. However, there is no project-level "dist" directory. I'm new to Foundation. It's not clear to me if there's supposed to be a project-level "dist" directory in v6.3.0 based on the latest release notes. Instead, the css and js folders are installed at the root level of the project as in prior versions. I installed Foundation via npm on Windows 7.

@kball
Copy link
Contributor

kball commented Dec 5, 2016

@jwatkin thanks for trying this out! I don't think we're going to have a project level "dist" folder inside the templates, this is the framework itself... For trying the basic template, can you try out this branch (not yet merged - we're still tweaking some final stuff in 6.3): https://github.com/zurb/foundation-sites-template/tree/v6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants