Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Styles #9304

Merged
merged 2 commits into from
Oct 29, 2016
Merged

Print Styles #9304

merged 2 commits into from
Oct 29, 2016

Conversation

andycochran
Copy link
Contributor

Adresses #9250.

  • Adds print, to the media types in media queries for named breakpoints up to and including the one matching $print-breakpoint
  • Adds a settings variable to disable printing href values after link text

@andycochran andycochran mentioned this pull request Oct 27, 2016
@kball
Copy link
Contributor

kball commented Oct 27, 2016

This is great! Nice work @andycochran. @anselmdk can you try this out for your use case?

@anselmdk
Copy link
Contributor

Nice guys, I'll try it out shortly.

@Owlbertz
Copy link
Contributor

Because 6.3 will be the next release and the v6.3 branch already got merged into develop, shouldn't this PR (and all other new ones) target develop rather than v6.3?

@andycochran
Copy link
Contributor Author

Ack! I did not know that 6.3 was in develop now. @kball let me know if I need to retarget this.

@andycochran
Copy link
Contributor Author

@brettsmason I'd be interested to hear what you think about the @function map-to-list that I added. The list $-zf-breakpoints-keys basically gives us a way to compare the indexes of the $print-breakpoint and whichever breakpoint passed to the breakpoint mixin. Can you think of a more efficient way to compare breakpoint indexes? I suppose the map-to-list function could be simplified, but it's a nice function that could be reused (I don't think it's too bloaty).

@brettsmason
Copy link
Contributor

No problem I'll take a look this evening when I'm home

@brettsmason
Copy link
Contributor

@andycochran The PR looks great to me, nice job!
That function looks especially useful, and might be of use for the whole vertical rhythm problem I'm working on. I would rather keep the function as you have it, rather than stripping it back.

Thumbs up from me 👍

@kball
Copy link
Contributor

kball commented Oct 29, 2016

I'm keeping 6.3 and develop in sync for right now... by our previous policy develop should be for next release, and 6.3 is our next release, however we have some outstanding PRs against 6.3, so for now either is fine.

@kball kball merged commit 9b30c04 into foundation:v6.3 Oct 29, 2016
@kball
Copy link
Contributor

kball commented Oct 29, 2016

Love the way this turned out. Thanks for putting it together @andycochran!

@anselmdk
Copy link
Contributor

Just added a screenshot to #9250 of how my initial use case looks with the new code - great work guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants