-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print Styles #9304
Print Styles #9304
Conversation
This is great! Nice work @andycochran. @anselmdk can you try this out for your use case? |
Nice guys, I'll try it out shortly. |
Because 6.3 will be the next release and the v6.3 branch already got merged into develop, shouldn't this PR (and all other new ones) target develop rather than v6.3? |
Ack! I did not know that 6.3 was in develop now. @kball let me know if I need to retarget this. |
@brettsmason I'd be interested to hear what you think about the |
No problem I'll take a look this evening when I'm home |
@andycochran The PR looks great to me, nice job! Thumbs up from me 👍 |
I'm keeping 6.3 and develop in sync for right now... by our previous policy develop should be for next release, and 6.3 is our next release, however we have some outstanding PRs against 6.3, so for now either is fine. |
Love the way this turned out. Thanks for putting it together @andycochran! |
Just added a screenshot to #9250 of how my initial use case looks with the new code - great work guys! |
Adresses #9250.
print,
to the media types in media queries for named breakpoints up to and including the one matching$print-breakpoint