Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9412 - import Sass dependencies in vendor folder #9458

Merged
merged 3 commits into from
Dec 6, 2016
Merged

Fix #9412 - import Sass dependencies in vendor folder #9458

merged 3 commits into from
Dec 6, 2016

Commits on Dec 6, 2016

  1. Fix foundation#9412 - import Sass dependencies in vendor folder 

    Previous PR: foundation#9449

Changes:
- Revert foundation#9430 - Make
`normalize-scss` a dev dependency.
- Copy Sass dependencies to `/_vendor/scss` and import them in Sass
from there.

Why not importing the Sass dependencies as real dependencies and from
`node_modules`: we cannot assume the path to our real dependencies. Old
npm versions store them in our `node_modules` folder, while newer
versions store them in the `node_modules` folder of the root project.
    @ncoden
    ncoden committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    5cf4425 View commit details
    Browse the repository at this point in the history

  2. Fix /_vendor ignore in .gitignore 

    Mistaken `.gitignore` with `.npmignore`. The `/vendor` directory should
be ignored by git, not npm.
    @ncoden
    ncoden committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    1974abd View commit details
    Browse the repository at this point in the history

  3. Move Sass dependencies from _vendor/scss to _vendor

    @ncoden
    ncoden committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    f61a7fb View commit details
    Browse the repository at this point in the history