fix: revert "6059743 unpin Meteor fourseven for better compatibility" #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a mistake of my own, I did not understood that Meteor will use versions to get "at least" the given version on installation. Removing it make Meteor searching for fourseven:scss@0.9.6 and break Sass compilation. Note: we may need to update to this package to Meteor 1.7.0.
ncoden
added a commit
to ncoden/motion-ui
that referenced
this pull request
Jun 13, 2018
Motion UI v2.0.2 (13 June 2018) This version fixes an issue introduced in `v2.0.1` preventing Meteor build and update Meteor installation documentation. It is fully compatible with `v2.0.1` and do not introduce any API change. Changes: * 🐛 foundation#121 - Revert "6059743 Unpin Meteor fourseven for a better Meteor compatibility" (@ncoden) * 📖 foundation#120 - Improve standard and Meteor documentation and update Meteor installation instructions (@ncoden)
ncoden
added a commit
to ncoden/motion-ui
that referenced
this pull request
Jun 13, 2018
Motion UI v2.0.2 (13 June 2018) This version fixes an issue introduced in `v2.0.1` preventing Meteor build and update Meteor installation documentation. It is fully compatible with `v2.0.1` and do not introduce any API change. Changes: * 🐛 foundation#121 - Revert "6059743 Unpin Meteor fourseven for a better Meteor compatibility" (@ncoden) * 📖 foundation#120 - Improve standard and Meteor documentation and update Meteor installation instructions (@ncoden)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a mistake of my own, I did not understood that Meteor will use versions to get "at least" the given version on installation. Removing it make Meteor searching for
fourseven:scss@0.9.6and break Sass compilation.Changes:
Note: The proper solution could be to update to Meteor v1.7.0.