Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forge snapshot: don't execute fuzz tests at all #1136

Closed
transmissions11 opened this issue Mar 30, 2022 · 2 comments · Fixed by #1141
Closed

forge snapshot: don't execute fuzz tests at all #1136

transmissions11 opened this issue Mar 30, 2022 · 2 comments · Fixed by #1141
Assignees
@transmissions11
Labels
A-gas-snapshots Area: gas snapshotting/reporting C-forge Command: forge D-easy Difficulty: easy P-low Priority: low T-feature Type: feature

Comments

@transmissions11
Copy link
Contributor

Component

Forge

Describe the feature you would like

due to PR #1134 fuzz tests are no longer included in the .gas-snapshot output of forge snapshot at all by default

for a significant performance boost we could simply not execute them when running forge snapshot (vs just hiding them from the output)

Additional context

No response
@transmissions11 transmissions11 added the T-feature Type: feature label Mar 30, 2022
@transmissions11
Copy link
Contributor Author

would be happy to try implementing but need some guidance on how to approach this 😅

@transmissions11
Copy link
Contributor Author

maybe a custom runner that filters out tests where func.inputs.is_empty() == false?

https://github.com/gakonst/foundry/blob/9ed6b8878c7c2daeb0a6b17ec3b9ff04e7752131/forge/src/runner.rs#L299

@transmissions11 transmissions11 mentioned this issue Mar 30, 2022
Merged
@onbjerg onbjerg added C-forge Command: forge P-low Priority: low D-easy Difficulty: easy A-gas-snapshots Area: gas snapshotting/reporting labels Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@transmissions11 transmissions11

Labels
A-gas-snapshots Area: gas snapshotting/reporting C-forge Command: forge D-easy Difficulty: easy P-low Priority: low T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

forge snapshot: don't execute fuzz tests at all by default transmissions11/foundry
2 participants
@onbjerg @transmissions11