Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge: only hide fuzz tests from snapshots (still show in tests) #1134

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

transmissions11
Copy link
Contributor

@transmissions11 transmissions11 commented Mar 30, 2022

Motivation

After some discussion with @mds1 we agreed that it would still be useful and cause no harm to always include fuzz test gas estimates in the standard test output.

Solution

Refactored the work done in #1086 to be limited only to snapshot exports.

Notes

May effect work done in #1130 and work planning to be done in #1088

@transmissions11
Copy link
Contributor Author

transmissions11 commented Mar 30, 2022

I recommend looking at the diff via the two commits (3835e52, 482082f) as a lot of the changes come from reverting the past PR 😅

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!
I'll think about how we catch these things during tests.

Failing test here unrelated.

@mattsse mattsse merged commit 97433f1 into foundry-rs:master Mar 30, 2022
@onbjerg onbjerg added the T-feature Type: feature label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature Type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants