Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forge coverage silently fails, showing zero coverage #3900

Closed
2 tasks done
OliverNChalk opened this issue Dec 17, 2022 · 0 comments · Fixed by #8268
Closed
2 tasks done

forge coverage silently fails, showing zero coverage #3900

OliverNChalk opened this issue Dec 17, 2022 · 0 comments · Fixed by #8268
Labels
C-forge Command: forge Cmd-forge-coverage Command: forge coverage T-bug Type: bug

Comments

@OliverNChalk
Copy link
Contributor

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (8fd5930 2022-12-16T00:10:59.201989698Z)

What command(s) is the bug in?

forge coverage

Operating System

Linux

Describe the bug

If forge coverage successfully compiles but the tests error, then it will produce a zero coverage report, which feels wrong. If the tests fail during coverage, which is possible because coverage compiles with different settings, then it should result in the command returning a non-zero exit code rather than silently failing and returning a zero coverage report.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-forge Command: forge Cmd-forge-coverage Command: forge coverage T-bug Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(coverage): exit early if tests failed foundry-rs/foundry
2 participants
@OliverNChalk @rkrasiuk