feat: factory skeleton

[petrovska-petro]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.97%. Comparing base (cc32c04) to head (21ec122).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #66       +/-   ##
===========================================
+ Coverage   87.27%   97.97%   +10.70%     
===========================================
  Files           3        2        -1     
  Lines         220      148       -72     
  Branches       23       27        +4     
===========================================
- Hits          192      145       -47     
+ Misses         27        1       -26     
- Partials        1        2        +1     

Files	Coverage Δ
src/RoboSaverVirtualModule.sol	99.19% <100.00%> (+10.11%)	⬆️
src/RoboSaverVirtualModuleFactory.sol	91.66% <91.66%> (ø)

... and 2 files with indirect coverage changes

[petrovska-petro]

wanted to check this prev, but it seems that in the test suite even if there were tests which failed still all checks are labelled as sucessful instead of blocking the merging? 🤔

[gosuto-inzasheru]

wanted to check this prev, but it seems that in the test suite even if there were tests which failed still all checks are labelled as sucessful instead of blocking the merging? 🤔

hmm you are right, this is due to foundry-rs/foundry#3900

easy fix would be to run it twice; forge t && forge coverage

i will push a commit

[gosuto-inzasheru]

also note heavy negative change in coverage

[gosuto-inzasheru]

• re Code run in setUp functions is not counted in coverage. foundry-rs/foundry#4553: indeed coverage is now at 100% for some files: https://app.codecov.io/gh/onchainification/robosaver/pull/66
• re feat(coverage): exit early if tests failed foundry-rs/foundry#8268: i removed the now unnecessary run of forge t in cc7ad57

[petrovska-petro]

• re Code run in setUp functions is not counted in coverage. foundry-rs/foundry#4553: indeed coverage is now at 100% for some files: https://app.codecov.io/gh/onchainification/robosaver/pull/66
• re feat(coverage): exit early if tests failed foundry-rs/foundry#8268: i removed the now unnecessary run of forge t in cc7ad57

that's great news ! great to see that increase of coverage, it can allow us to raise our standards of the MIN before merging

[gosuto-inzasheru]

i pushed a bit hacky way to ignore the scripts from showing up in the codecov report

better will be the merging of this branch: foundry-rs/foundry#7301

[gosuto-inzasheru]

hmm i guess we want to ignore test/ as well for the coverage report..?

[petrovska-petro]

hmm i guess we want to ignore test/ as well for the coverage report..?

yes, makes sense to exclude test/ & script/ completely