Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(forge): forge update recursively fetches latest submodules #5926

Closed
2 tasks
emo-eth opened this issue Sep 26, 2023 · 0 comments · Fixed by #5980
Closed
2 tasks

bug(forge): forge update recursively fetches latest submodules #5926

emo-eth opened this issue Sep 26, 2023 · 0 comments · Fixed by #5980
Labels
T-bug Type: bug

Comments

@emo-eth
Copy link
Contributor

emo-eth commented Sep 26, 2023

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (80df71f 2023-09-26T18:05:26.004416000Z)

What command(s) is the bug in?

forge update

Operating System

macOS (Apple Silicon)

Describe the bug

forge update always passes the --recursive flag to the git submodule update command, which recursively fetches the latest commit for every submodule, including submodules inherited by submodules.

This makes deterministic builds difficult with forge update because updating a submodule A means updating all submodule dependencies therein, regardless of whether or not the latest submodule A is using the latest version of submodule B.

--recursive should not be the default, but should be available as a command-line flag.

This is a regression of issue #2264 which was fixed in #2274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant