Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --recursive flag from git submodule call in forge update #2274

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

ckoopmann
Copy link
Contributor

Motivation

Currently forge update recursively updates nested dependencies which can lead to problems outlined in #2264

Solution

Remove --recursive flag from git submodule call inside forge update subcommand.

@ckoopmann ckoopmann marked this pull request as draft July 12, 2022 00:58
@ckoopmann ckoopmann marked this pull request as ready for review July 12, 2022 03:02
@ckoopmann
Copy link
Contributor Author

ckoopmann commented Jul 12, 2022

Note that the integration tests i added depends on a repository that I created using my personal github account for reproducing this issue.
Lmk if this is an issue and I can remove the test or see if there is a way to reproduce the issue using existing repos.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's reasonable, user can execute recursive updates manually

wdyt @onbjerg ?

@mattsse mattsse added the L-ignore Log: ignore PR in changelog label Jul 12, 2022
@gakonst
Copy link
Member

gakonst commented Jul 12, 2022

Note that the integration tests i added depends on a repository that I created using my personal github account for reproducing this issue.

Thanks! Very helpful. Upstreamed this here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-ignore Log: ignore PR in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants