Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass http headers for --fork-url #6173

Closed
vbrvk opened this issue Oct 30, 2023 · 2 comments · Fixed by #6178
Closed

Allow to pass http headers for --fork-url #6173

vbrvk opened this issue Oct 30, 2023 · 2 comments · Fixed by #6178
Assignees
Labels
C-anvil Command: anvil good first issue Good for newcomers T-feature Type: feature

Comments

@vbrvk
Copy link
Contributor

vbrvk commented Oct 30, 2023

Component

Anvil

Describe the feature you would like

I trying to setup e2e testing with anvil, my private node protected by http header with token, but anvil does not support passing http headers to fork url.

It would be nice to have such option, for example under --fork-header key with support of multiple headers at once

Additional context

No response

@vbrvk vbrvk added the T-feature Type: feature label Oct 30, 2023
@vbrvk
Copy link
Contributor Author

vbrvk commented Oct 30, 2023

I would like to implement this feature by myself, if we are agree on param name and if it is useful at all

@mattsse
Copy link
Member

mattsse commented Oct 31, 2023

cool, I think this is reasonable.

the argument should be called --fork-headers: Vec<String> I think,

and should be grouped with the existing fork attributes:

pub fork_url: Option<String>,

then we need support for this here:

pub struct ProviderBuilder {

and

"http" | "https" => {

@Evalir Evalir added the good first issue Good for newcomers label Oct 31, 2023
@Evalir Evalir added the C-anvil Command: anvil label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-anvil Command: anvil good first issue Good for newcomers T-feature Type: feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants