Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anvil): allow pass headers to fork-url #6178

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

vbrvk
Copy link
Contributor

@vbrvk vbrvk commented Oct 31, 2023

Closes #6173

@vbrvk vbrvk marked this pull request as ready for review October 31, 2023 16:34
@vbrvk vbrvk marked this pull request as draft October 31, 2023 16:36
@vbrvk
Copy link
Contributor Author

vbrvk commented Oct 31, 2023

image

After added headers param clippy does not satisfied with too many arguments. @Evalir what do you think the best option to fix it?

@vbrvk vbrvk marked this pull request as ready for review November 1, 2023 09:02
@Evalir Evalir requested a review from mattsse November 1, 2023 14:33
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rm all additional ;

makes it harder to review

@vbrvk
Copy link
Contributor Author

vbrvk commented Nov 1, 2023

Fixed, actually I was thinking about not adding them, but contributing guide recommends to enable formatOnSave option, so I did :)

@vbrvk vbrvk requested a review from mattsse November 1, 2023 19:12
@Evalir
Copy link
Member

Evalir commented Nov 1, 2023

yep @vbrvk we use nightly clippy/formatting, so the appropiate command should be cargo +nightly fmt—we can probably make this a bit clearer in the contribution guide

crates/common/src/runtime_client.rs Outdated Show resolved Hide resolved
@vbrvk vbrvk requested a review from Evalir November 3, 2023 08:55
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

ty

@mattsse mattsse merged commit 1c7bf46 into foundry-rs:master Nov 3, 2023
15 of 16 checks passed
@vbrvk vbrvk deleted the feat/pr-6173-fork-headers branch November 3, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to pass http headers for --fork-url
3 participants