Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foundryup fails if FOUNDRY_BIN_DIR is not in the PATH #6369

Closed
2 tasks done
warrickwicket opened this issue Nov 20, 2023 · 0 comments · Fixed by #6377
Closed
2 tasks done

Foundryup fails if FOUNDRY_BIN_DIR is not in the PATH #6369

warrickwicket opened this issue Nov 20, 2023 · 0 comments · Fixed by #6377
Labels
T-bug Type: bug

Comments

@warrickwicket
Copy link

Component

Foundryup

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

master branch

What command(s) is the bug in?

foundryup

Operating System

Linux

Describe the bug

#6352 has made foundryup stricter.
This has created a breaking change in how foundryup behaves: if FOUNDRY_BIN_DIR is not in the PATH, foundryup will fail because the which command will fail, and the script will stop.
This means the binaries will be installed, but the script will exit with a status of 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bug Type: bug
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(foundryup): don't fail on 'which' check foundry-rs/foundry
1 participant
@warrickwicket