fix(foundryup): actually make set -e work

[DaniPopes]

Motivation

Fixes #6329

TIL that using || on a function disables the global set -e for the function. lol.

5:18
https://youtu.be/30YWsGDr8mA?si=FfN-Fdbadxu_yJnZ&t=318

Solution

[Evalir]

Oh wow, TIL!

[warrickwicket]

This is a breaking change. foundryup now returns 1 if FOUNDRY_BIN_DIR is not in the PATH, which is not unreasonable for CI setups. I think it might make sense to relax this requirement.

[DaniPopes]

How would foundryup fail if FOUNDRY_BIN_DIR is not in PATH? Can you please open an issue

[warrickwicket]

which EXECUTABLE returns 1, and that terminates the script with 1. I'll open a more detailed issue

[imulmat4]

Any chance we could revert this change? Not sure this exit is giving a ton of value.