Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getLabel should be marked as "view" #6695

Closed
2 tasks
drortirosh opened this issue Jan 2, 2024 · 0 comments · Fixed by #6700
Closed
2 tasks

getLabel should be marked as "view" #6695

drortirosh opened this issue Jan 2, 2024 · 0 comments · Fixed by #6700
Labels
T-bug Type: bug

Comments

@drortirosh
Copy link

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (a5171a4 2023-12-23T00:20:38.972936000Z)

What command(s) is the bug in?

No response

Operating System

None

Describe the bug

the getLabel function is a view function, but its interface definition in "Vm" is missing the keyword "view"
@drortirosh drortirosh added the T-bug Type: bug label Jan 2, 2024
@gakonst gakonst added this to Foundry Jan 2, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Jan 2, 2024
@Evalir Evalir mentioned this issue Jan 3, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bug Type: bug
Projects
Foundry
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(cheatcodes): mark getLabel as view foundry-rs/foundry
1 participant
@drortirosh