Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cheatcodes): mark getLabel as view #6700

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented Jan 3, 2024

Motivation

Closes #6695

Solution

Should be marked as view.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

this needs a forge-std companion?

@Evalir
Copy link
Member Author

Evalir commented Jan 3, 2024

yep! we just need to run a script to update forge-std, see: foundry-rs/forge-std#487

@Evalir Evalir merged commit 47b3695 into master Jan 3, 2024
18 of 19 checks passed
@Evalir Evalir deleted the evalir/mark-label-view branch January 3, 2024 20:32
@mds1
Copy link
Collaborator

mds1 commented Jan 9, 2024

Can someone run that script and open the PR? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getLabel should be marked as "view"
3 participants