debt(anvil): migrate to use op-alloy optimism types

[Evalir]

TBD yet if this should go on alloy—but we should refactor out the Optimism types as the network abstraction comes together. #6808 (comment)

Edit: Optimism types have since moved to https://github.com/alloy-rs/op-alloy

Updated the ticket to reflect that we should use those types in Foundry instead of the local implementation

[leovct]

Hi, I'd like to tackle this issue if it is still relevant!

[zerosnacks]

Hi, I'd like to tackle this issue if it is still relevant!

Awesome thanks, yes this is still relevant:

See:

• https://github.com/foundry-rs/foundry/blob/da77402c298066b084547c6027f1c9e3104fe871/crates/anvil/core/src/eth/transaction/optimism.rs
• https://github.com/foundry-rs/foundry/blob/da77402c298066b084547c6027f1c9e3104fe871/crates/anvil/tests/it/optimism.rs

[leovct]

I've noticed that there are also references to revm::primitives::OptimismFields, is it in the scope of this PR also?

https://github.com/foundry-rs/foundry/blob/master/crates/anvil/src/eth/backend/mem/mod.rs#L92

[zerosnacks]

I've noticed that there are also references to revm::primitives::OptimismFields, is it in the scope of this PR also?

https://github.com/foundry-rs/foundry/blob/master/crates/anvil/src/eth/backend/mem/mod.rs#L92

Possibly not but worth looking into, I think Reth still uses its own Optimism types

[zerosnacks]

Related: #8943

use TxDeposit from op-alloy-consensus

Replace the existing DepositTransaction

foundry/crates/anvil/core/src/eth/transaction/optimism.rs

Line 277 in 07a1f67

pub struct DepositTransaction {

with TxDeposit from op-alloy: https://github.com/alloy-rs/op-alloy/blob/f6d9d723fff605c8b87a95548d4eb56338dc2c1e/crates/consensus/src/transaction/deposit.rs#L15

[zerosnacks]

Related PR: #8595 + ticket #8575

this anvil type

foundry/crates/anvil/core/src/eth/transaction/optimism.rs

Line 13 in c998542

pub struct DepositTransactionRequest {

should be equivalent to

https://github.com/alloy-rs/op-alloy/blob/2ecb2e50ec705df6615596b6c5bde879c6f7dee1/crates/consensus/src/transaction/deposit.rs#L12

and could be replaced

[leovct]

I think this issue can be closed, #9047 just got merged :)