Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

struct DepositTransaction replace by struct TxDeposit #8943 #8944

Closed
wants to merge 2 commits into from
Closed

struct DepositTransaction replace by struct TxDeposit #8943 #8944

wants to merge 2 commits into from

Conversation

pratikramteke
Copy link

Motivation

Solution

yash-atreya
yash-atreya reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not right. You need to add op-alloy-consensus as a dep and import TxDeposit from it.

@zerosnacks
Copy link
Member

Thanks for your PR, unfortunately will have to close it as it is already part of #6860

@zerosnacks zerosnacks closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash-atreya yash-atreya yash-atreya left review comments

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pratikramteke @zerosnacks @yash-atreya