Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge flatten : Failed to flatten: missing field block #7069

Closed
2 tasks done
Metaxona opened this issue Feb 9, 2024 · 2 comments · Fixed by #7077
Closed
2 tasks done

forge flatten : Failed to flatten: missing field block #7069

Metaxona opened this issue Feb 9, 2024 · 2 comments · Fixed by #7077
Assignees
Labels
T-bug Type: bug

Comments

@Metaxona
Copy link

Metaxona commented Feb 9, 2024

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (b174c3a 2024-02-09T00:16:22.953958126Z)

What command(s) is the bug in?

forge flatten

Operating System

Linux

Describe the bug

UUPS Contract Implementations are not getting flattened, only the proxy contracts and other specified contracts are getting flattened

errors are showing:
Failed to flatten: missing field block at line 1 column 194281
Failed to flatten: missing field block at line 1 column 492135

when it's the implementation's turn to be flattened

image

tried it on WSL
image

and on Ubuntu server
image

forge 0.2.0 (b174c3a 2024-02-09T00:16:22.953958126Z)

ending up with the same result

@Metaxona Metaxona added the T-bug Type: bug label Feb 9, 2024
@klkvr klkvr self-assigned this Feb 9, 2024
@klkvr
Copy link
Member

klkvr commented Feb 9, 2024

hey @Metaxona thank you for the report! any chance you could share a repro for this?

If the code being flattened contains do-while blocks than I probably know what might be causing this, but otherwise a repro would be very useful here

@Metaxona
Copy link
Author

Metaxona commented Feb 9, 2024

hey @Metaxona thank you for the report! any chance you could share a repro for this?

If the code being flattened contains do-while blocks than I probably know what might be causing this, but otherwise a repro would be very useful here

yeah it does indeed contain a do while loop, several of them. though I am currently not able to share the repo since it's a private and not a personal repo

but i did use do while loops in-place of all or most for loop applications

mattsse pushed a commit to foundry-rs/compilers that referenced this issue Feb 9, 2024
Fixes AST field name for `DoWhileStatement` nodes.

Ref foundry-rs/foundry#7069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants