Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompiling on every forge test run #713

Closed
2 tasks
odd-amphora opened this issue Feb 10, 2022 · 4 comments · Fixed by gakonst/ethers-rs#893
Closed
2 tasks

Recompiling on every forge test run #713

odd-amphora opened this issue Feb 10, 2022 · 4 comments · Fixed by gakonst/ethers-rs#893
Labels
T-bug Type: bug

Comments

@odd-amphora
Copy link

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.1.0 (fcc0fe5 2022-02-10T00:02:11.333815+00:00)

What command(s) is the bug in?

forge test

Operating System

macOS (M1)

Describe the bug

Subsequent calls to forge test cause contracts to be recompiled, even though no files have been changed.

@odd-amphora odd-amphora added the T-bug Type: bug label Feb 10, 2022
@mattsse
Copy link
Member

mattsse commented Feb 10, 2022

sounds like a cache bug, could you link me to the repo that's causing this or provide me with a minimal repro?

@odd-amphora
Copy link
Author

https://github.com/jbx-protocol/juice-contracts-v2

@mattsse
Copy link
Member

mattsse commented Feb 10, 2022

thanks, will get that fixed!

@mattsse
Copy link
Member

mattsse commented Feb 10, 2022

@odd-amphora thanks, was able to find and fix a couple of issues here gakonst/ethers-rs#893

however, due to the ambiguity of remappings (dapptools/hardhat) you'd need to explicitly list the remappings either in a foundry.toml

[default]
libs = ['node_modules']
out = 'out'
remappings = [
  '@chainlink/=node_modules/@chainlink/',
  '@ensdomains/=node_modules/@ensdomains/',
  '@openzeppelin/=node_modules/@openzeppelin/',
  '@paulrberg/=node_modules/@paulrberg/',
  'eth-gas-reporter/=node_modules/eth-gas-reporter/',
  'hardhat-deploy/=node_modules/hardhat-deploy/',
  'hardhat/=node_modules/hardhat/',
  'prb-math/=node_modules/prb-math/',
]
src = 'contracts'

or only the remappings in a remappings.txt file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants