Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix(solc): resolver and remapping auto detection bugs #893

Merged
merged 7 commits into from
Feb 10, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 10, 2022

Motivation

Fixes several remappings related bugs, Closes foundry-rs/foundry#713

Solution

  • handle contracts/src edge case as in @chainlink/contracts/src/{v.0.8, v0.9}
  • handle edge case introduced in fix(solc): support remapping autodetection edge case #888 : distinguish between dapptools and hardhat style before merging multiple remapping candidates on the same level.
  • better error message if a file couldn't be resolved
  • fix import detection bug where imports in single quotes were ignored

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@gakonst gakonst merged commit 331caf9 into gakonst:master Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recompiling on every forge test run
2 participants