Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] change forge build sizes report to Bytes #7567

Closed
2 tasks done
radeksvarz opened this issue Apr 5, 2024 · 1 comment · Fixed by #7588
Closed
2 tasks done

[Improvement] change forge build sizes report to Bytes #7567

radeksvarz opened this issue Apr 5, 2024 · 1 comment · Fixed by #7588
Labels
first issue A good way to start contributing T-feature Type: feature

Comments

@radeksvarz
Copy link

radeksvarz commented Apr 5, 2024

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (dbc48ea 2024-04-03T00:17:03.697365187Z)

What command(s) is the bug in?

forge build

Operating System

Linux

Describe the bug

forge build --sizes lists values for size and margin in kB. It is unclear whether 1000x or 1024x

It would be more clear if listed in Bytes right aligned as the sizes are up to 5 digits anyway.

image

To become :

Compiler run successful!
| Contract                       | Size (B)  | Margin (B)  |
|--------------------------------|-----------|-------------|
| Address                        |        86 |      24 490 |
| SomeHugeContract               |    17 906 |       6 670 |
@radeksvarz radeksvarz added the T-bug Type: bug label Apr 5, 2024
@DaniPopes DaniPopes added first issue A good way to start contributing T-feature Type: feature and removed T-bug Type: bug labels Apr 5, 2024
@radeksvarz
Copy link
Author

Wow, that was a quick response. You guys are awesome.

Yet I proposed to right aligned the values (for easy comparison).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first issue A good way to start contributing T-feature Type: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants