Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(forge): kB to B in build --sizes #7588

Merged
merged 2 commits into from
Apr 8, 2024
Merged

chore(forge): kB to B in build --sizes #7588

merged 2 commits into from
Apr 8, 2024

Conversation

kamuik16
Copy link
Contributor

@kamuik16 kamuik16 commented Apr 7, 2024

Closes #7567

@kamuik16
Copy link
Contributor Author

kamuik16 commented Apr 7, 2024

Example Output:

Compiler run successful!
| Contract | Size (B) | Margin (B) |
|----------|----------|------------|
| Counter  | 247      | 24329      |

onbjerg
onbjerg requested changes Apr 8, 2024
View reviewed changes
crates/common/src/compile.rs Outdated Show resolved Hide resolved
@onbjerg onbjerg self-assigned this Apr 8, 2024
@kamuik16 kamuik16 requested a review from onbjerg April 8, 2024 05:09
Evalir
Evalir approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

DaniPopes
DaniPopes approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit 5274799 into foundry-rs:master Apr 8, 2024
19 checks passed
@kamuik16 kamuik16 deleted the kamuik16/7567 branch April 8, 2024 10:35
This was referenced Apr 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees

@onbjerg onbjerg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] change forge build sizes report to Bytes
4 participants
@kamuik16 @onbjerg @Evalir @DaniPopes