Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add etherscan table #2616

Merged
merged 12 commits into from
Aug 12, 2022
Merged

feat: add etherscan table #2616

merged 12 commits into from
Aug 12, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Aug 4, 2022 •
edited
Loading

Motivation

Closes #2609

Add standalone etherscan_configs table

That supports different chain_alias = {key = ""} entries.
the --etherscan-api-key is now used to lookup chain_alias, if no alias found it's treated as API key, like before

Solution

@mattsse mattsse added the T-feature Type: feature label Aug 4, 2022
@mattsse mattsse marked this pull request as draft August 4, 2022 16:19
@mattsse mattsse mentioned this pull request Aug 9, 2022
Merged
3 tasks
@mattsse mattsse marked this pull request as ready for review August 11, 2022 17:24
onbjerg
onbjerg requested changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think [etherscan] or [etherscan_keys] makes more sense

@onbjerg onbjerg linked an issue Aug 11, 2022 that may be closed by this pull request
Improve etherscan-api-key cli arguments #2074
Closed
2 tasks
@onbjerg onbjerg mentioned this pull request Aug 11, 2022
Closed
2 tasks
@mattsse mattsse changed the title feat: add etherscan_api_keys table feat: add etherscan table Aug 12, 2022
@mattsse
Copy link
Member Author

mattsse commented Aug 12, 2022

renamed to [etherscan]

@mattsse mattsse requested a review from onbjerg August 12, 2022 17:08
gakonst
gakonst approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@gakonst gakonst merged commit e385736 into foundry-rs:master Aug 12, 2022
@mattsse mattsse mentioned this pull request Aug 25, 2022
Closed
2 tasks
iFrostizz pushed a commit to iFrostizz/foundry that referenced this pull request Nov 9, 2022
@mattsse @iFrostizz
feat: add etherscan table (foundry-rs#2616)
675ea54 
* chore: rename rpc endpoints

* fix: rename endpoints

* rename to RpcEndpoints again

* more work on etherscan table

* bump ethers

* feat: support etherscan table

* fix test

* rename etherscan_configs --> etherscan

* integrate etherscan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add etherscan_api_keys table Improve etherscan-api-key cli arguments
3 participants
@mattsse @onbjerg @gakonst