Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forge): support solc --include-path #2747

Merged
merged 8 commits into from
Aug 12, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Aug 12, 2022

Blocked by gakonst/ethers-rs#1590

Motivation

Closes #2706

Solution

  • drops custom remappings for src, test, script, is now handled via --include-path
  • add include-paths config
  • add tests

@mattsse mattsse added T-feature Type: feature C-forge Command: forge labels Aug 12, 2022
@mattsse mattsse changed the title Matt/support include paths feat(forge): support solc --include-path Aug 12, 2022
@mds1
Copy link
Collaborator

mds1 commented Aug 12, 2022

Tested this out and confirmed it resolves #2706

@mattsse
Copy link
Member Author

mattsse commented Aug 12, 2022

all forge test pass: https://github.com/foundry-rs/foundry/runs/7809997586?check_suite_focus=true

just needs ethers bump

@gakonst
Copy link
Member

gakonst commented Aug 12, 2022

PR merged, bump ethers and good to go

@mattsse mattsse marked this pull request as ready for review August 12, 2022 20:51
@mattsse mattsse merged commit e3557c7 into foundry-rs:master Aug 12, 2022
iFrostizz pushed a commit to iFrostizz/foundry that referenced this pull request Nov 9, 2022
* feat: support solc --include-path

* feat: support include-path

* chore: rustfmt

* bump

* revert cargo patch

* bump ethers

* bump ethers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge T-feature Type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: absolute path remappings not handled properly
3 participants