Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(verify): add use_literal_content config option #3009

Closed
wants to merge 1 commit into from

Conversation

rkrasiuk
Copy link
Collaborator

@rkrasiuk rkrasiuk commented Aug 29, 2022

Motivation

Etherscan cannot verify contracts compiled with via-ir and containing more than one contract source. closes #2996

Solution

expose the useLiteralContent setting

@rkrasiuk rkrasiuk added T-bug Type: bug C-forge Command: forge Cmd-forge-verify Command: forge verify-contract/check labels Aug 29, 2022
@rkrasiuk rkrasiuk requested a review from mattsse August 29, 2022 16:09
@rkrasiuk
Copy link
Collaborator Author

@mattsse hmm, maybe i should add some warning as well

@gakonst
Copy link
Member

gakonst commented Aug 29, 2022

How does exposing this config help?

@rkrasiuk
Copy link
Collaborator Author

@gakonst that's the only way i managed to verify the contract with --via-ir and multiple source files. etherscan for some reason complains about parsing URLs. the exact message from the UI is

Unable to process the standard-input-json you uploaded. ErrCode: Only literal contents of the source file, Source using URLS are not supported

@mattsse
Copy link
Member

mattsse commented Aug 29, 2022

why are there urls in the standard-input-json in the first place?

@rkrasiuk
Copy link
Collaborator Author

after a few more tests, i'm closing this PR. it appears I'm yet to find the root cause

@rkrasiuk rkrasiuk closed this Aug 29, 2022
@rkrasiuk rkrasiuk deleted the rkrasiuk/fix-verify-use-literal-content branch August 29, 2022 18:13
@wighawag
Copy link

wighawag commented Apr 16, 2023

Hey, was looking for the option to export metadata as a single file with useLiteralContent and found this PR

Is there any way to set that option in forge setting ?

This is a very useful feature to save the compilation input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-verify Command: forge verify-contract/check T-bug Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forge verify-contract is unable to verify
4 participants