fix(forge/script): deployment size check #3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Sep 14, 2022
mattsse
requested changes
Sep 14, 2022
mattsse
approved these changes
Sep 14, 2022
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
* fix(forge/script): deployment size check * chore: clippy * chore: fmt * add comments * fix: prompt user out of the loop * fix: bail instead of panicking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Deployment sizes check introduced in #2619 would not work for arbitrary bytecode deployed without an artifact and thus pass without errors.
Solution
Check against bytecodes from both artifacts and traces
Tested with, closes #2923:
Before: https://mumbai.polygonscan.com/tx/0xcf74fcecf15120bcf703598b4f47411f46210a5b6ffcef46a3e3919fd04f629b
(max codesize exceeded revert)
After:
