test: add test for absolute imports from test and script #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reproduction case here, more info in that README: https://github.com/mds1/forge-test-my-proj I'm going to update #3440 to clarify the issue |
|
I see, so the problem seems to that remappings take precedence over absolute imports so if an import path starts with since this happens in a dependency this is actually this issue #1855 |
|
merging this as is and keep the issue opne |
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ref #3440
@mds1 do you have an example where this currently fails? Because this test passes
Solution